Difference between revisions of "Talk:Spell Format"

From VCMI Project Wiki
Jump to: navigation, search
(Spell levels)
Line 15: Line 15:
 
}
 
}
 
</syntaxhighlight>
 
</syntaxhighlight>
 +
[[User:Ivan|Ivan]] ([[User talk:Ivan|talk]]) 15:09, 4 March 2013 (CET)
 
:Please take a look at new version.--[[User:AVS|AVS]] ([[User talk:AVS|talk]]) 11:59, 4 March 2013 (CET)
 
:Please take a look at new version.--[[User:AVS|AVS]] ([[User talk:AVS|talk]]) 11:59, 4 March 2013 (CET)
 +
:: Looks good.
 +
:: - "power" - Can you expand that 2-word description?
 +
:: - "kind" - "type" is probably a better name. And "ability" should be renamed to "special" (e.g. Titan Thunder is special spell but not an ability) or even move it to separate field for consistency with other formats.
 +
 +
:: And some ideas for future. I'm not going to insist on any of them so it's up to you (or to whoever will implement this config in code)
 +
:: - turn such groups like mind spells into "spell schools" - they won't have skill or anything like that but will allow merging of MIND_IMMUNITY with SCHOOL_IMMUNITY bonuses + modders will be able to define any new groups.
 +
:: - perhaps merge "effects" with "flags"? "offensive" are obviously negative and "rising" are positive. No need to duplicate it.
 +
:: [[User:Ivan|Ivan]] ([[User talk:Ivan|talk]]) 15:09, 4 March 2013 (CET)

Revision as of 14:09, 4 March 2013

Spell levels

I don't like how spell levels are described here. Perhaps instead of dozen of 4-element arrays use 4 sub-records?

"levels": [
{ // no skill
    "cost" : 5,
    "target" : "CREATURE",
    ...
},
...
{ // expert
    "cost" : 2,
    "target" : "NO_TARGET",
    ...
}

Ivan (talk) 15:09, 4 March 2013 (CET)

Please take a look at new version.--AVS (talk) 11:59, 4 March 2013 (CET)
Looks good.
- "power" - Can you expand that 2-word description?
- "kind" - "type" is probably a better name. And "ability" should be renamed to "special" (e.g. Titan Thunder is special spell but not an ability) or even move it to separate field for consistency with other formats.
And some ideas for future. I'm not going to insist on any of them so it's up to you (or to whoever will implement this config in code)
- turn such groups like mind spells into "spell schools" - they won't have skill or anything like that but will allow merging of MIND_IMMUNITY with SCHOOL_IMMUNITY bonuses + modders will be able to define any new groups.
- perhaps merge "effects" with "flags"? "offensive" are obviously negative and "rising" are positive. No need to duplicate it.
Ivan (talk) 15:09, 4 March 2013 (CET)